Skip to content

Refactor createTransactionHash and MerkleHashBuilder #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 21, 2019
Merged

Refactor createTransactionHash and MerkleHashBuilder #359

merged 7 commits into from
Nov 21, 2019

Conversation

evias
Copy link
Contributor

@evias evias commented Nov 21, 2019

Changed

  • Refactor of Transaction.createTransactionHash for clarity and use protocol nearest transaction creation flow as seen in TransactionExtensions
  • MerkleHashBuilder now creates hasher from instance parameters
  • Fix usage of SHA3 for transaction hashes in Transaction.createTransactionHash and `AggregateTransaction.calculateInnerTransactionHash

@coveralls
Copy link

coveralls commented Nov 21, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 841

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 838: 0.0%
Covered Lines: 10
Relevant Lines: 10
💛 - Coveralls

rg911
rg911 suggested changes Nov 21, 2019
View reviewed changes
src/model/transaction/Transaction.ts
* @param {NetworkType} networkType Catapult network identifier
* @returns {string} Returns Transaction Payload hash
*/
public static createTransactionHash(transactionPayload: string, generationHashBuffer: number[], networkType: NetworkType): string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, don't think we need networkType anymore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one i would rather keep as it affects CosignatureTransaction down the road ; lets wait for more clarity on keccak for removing it ?

@rg911 rg911 merged commit 181d926 into symbol:master Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rg911 rg911 rg911 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@evias @coveralls @rg911